chore: Feat + Fix: added searchbar + emoji name and fixed emoji picker position #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Spiral-Memory
force-pushed
the
develop
branch
from
2ef2985 to
8f3bb40
Compare
|
Could you make the search input smaller and match its background color with the emoji background? This was previously implemented, but I removed it because I couldn't match the colors across all themes. If you can handle that, it’ll be good to merge this. Thanks! |
|
sure @Spiral-Memory . Can you explain more about feature you are asking for ? |
|
hey @Spiral-Memory I have made changes as you said in ace81f0. Take a look Recording.2025-01-29.170949.mp4 |
|
Looks good to me, Thanks @Stpriyasharma |
Spiral-Memory
changed the title
|
Hi @Stpriyasharma |
…into feat+fix/add-searchbar-description-in-emojiePicker
Stpriyasharma
force-pushed
the
feat+fix/add-searchbar-description-in-emojiePicker
branch
from
0367300 to
ad5fbd5
Compare
|
Still format check is failing @Stpriyasharma |
Spiral-Memory
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Title
Added search section and description (name) of emoji on mouse hover as well as fixes the emoji picker integration within the chat input section.
Acceptance Criteria fulfillment
Searchbar : User doesn't need to search manually emoji
emoji description(name) : Helps to choose emoji properly through its description
emoji picker not within chat input.
Fixes #928
Fixes #929
Video/Screenshots
Recording.2025-01-24.225034.mp4
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-930